Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in new pass removed from InstCombine in refactor #2819

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

dstutt
Copy link
Member

@dstutt dstutt commented Nov 15, 2023

Upstream LLVM refactored InstCombine to extract a new InferAlignment pass which needs adding back in to the passes being run.

@dstutt dstutt requested a review from a team as a code owner November 15, 2023 16:11
@amdvlk-admin
Copy link

49168dd Jenkins build error.
/jenkins/workspace/vulkan/sanitized-opensource/Github-PR/llpc-github-pr/driver_build/drivers/llpc/lgc/patch/VertexFetch.cpp:1538:78: error: reference to ‘Builder’ is ambiguous
1538 | builderImpl.getInt32(0), Builder::BufferFlagAddress);
| ^~~~~~~
In file included from /jenkins/workspace/vulkan/sanitized-opensource/Github-PR/llpc-github-pr/driver_build/drivers/llpc/lgc/include/lgc/builder/BuilderImpl.h:33,
from /jenkins/workspace/vulkan/sanitized-opensource/Github-PR/llpc-github-pr/driver_build/drivers/llpc/lgc/include/lgc/patch/VertexFetch.h:34,
from /jenkins/workspace/vulkan/sanitized-opensource/Github-PR/llpc-github-pr/driver_build/drivers/llpc/lgc/patch/VertexFetch.cpp:31:

/jenkins/workspace/vulkan/sanitized-opensource/Github-PR/llpc-github-pr/driver_build/drivers/llpc/lgc/patch/VertexFetch.cpp:1546:77: error: reference to ‘Builder’ is ambiguous
1546 | builderImpl.getInt32(binding), Builder::BufferFlagNonConst);
| ^~~~~~~
In file included from /jenkins/workspace/vulkan/sanitized-opensource/Github-PR/llpc-github-pr/driver_build/drivers/llpc/lgc/include/lgc/builder/BuilderImpl.h:33,
from /jenkins/workspace/vulkan/sanitized-opensource/Github-PR/llpc-github-pr/driver_build/drivers/llpc/lgc/include/lgc/patch/VertexFetch.h:34,
from /jenkins/workspace/vulkan/sanitized-opensource/Github-PR/llpc-github-pr/driver_build/drivers/llpc/lgc/patch/VertexFetch.cpp:31:

Copy link
Member

@nhaehnle nhaehnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental llvm-dialects update? LGTM apart from that.

@dstutt
Copy link
Member Author

dstutt commented Nov 15, 2023

Accidental llvm-dialects update? LGTM apart from that.

Thanks - I was just trying to work out why it was failing.

Upstream LLVM refactored InstCombine to extract a new InferAlignment pass which
needs adding back in to the passes being run.
@amdvlk-admin
Copy link

Test summary for commit 88b6c1b

CTS tests (Failed: 0/138362)
  • Built with version 1.3.5.2
  • Ubuntu navi3x, Srdcvk
    • Passed: 35162/69147 (50.9%)
    • Failed: 0/69147 (0.0%)
    • Not Supported: 33985/69147 (49.1%)
    • Warnings: 0/69147 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35242/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@dstutt dstutt merged commit 03384c3 into GPUOpen-Drivers:dev Nov 15, 2023
9 checks passed
@dstutt dstutt deleted the infer-align-pass branch November 15, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants